Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Conditional extender instantiation #3898

Merged
merged 12 commits into from
Oct 18, 2023
Merged

[1.x] Conditional extender instantiation #3898

merged 12 commits into from
Oct 18, 2023

Conversation

imorland
Copy link
Member

@imorland imorland commented Oct 11, 2023 •
edited
Loading

Addresses #3897

@imorland imorland requested a review from a team as a code owner October 11, 2023 07:44
@imorland imorland linked an issue Oct 11, 2023 that may be closed by this pull request
[1.x] Conditional extender instantiates the extenders array even when the conditional is false #3897
Closed
@imorland imorland changed the title [1.x] Conditional extender instantiation WIP: [1.x] Conditional extender instantiation Oct 11, 2023
@imorland imorland added this to the 1.8.3 milestone Oct 11, 2023
@imorland imorland changed the title WIP: [1.x] Conditional extender instantiation [1.x] Conditional extender instantiation Oct 11, 2023
@imorland imorland requested a review from SychO9 October 11, 2023 16:41
@imorland imorland merged commit c3fadbf into 1.x Oct 18, 2023
264 checks passed
@imorland imorland deleted the im/conditional-extender branch October 18, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
prio/high type/extensibility
Projects
None yet
Milestone
1.8.3
Development

Successfully merging this pull request may close these issues.

[1.x] Conditional extender instantiates the extenders array even when the conditional is false
3 participants
@imorland @SychO9 @StyleCIBot