Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1.x,approval): correct PostWasApproved event trigger condition #3925

Merged
merged 5 commits into from
Nov 17, 2023

Commits on Nov 6, 2023

  1. fix: correct PostWasApproved event trigger condition

    Ensure the PostWasApproved event is only raised for posts that are not hidden. This fixes the issue where the event was incorrectly triggered for hidden posts. Additionally, the post's approval status is set to true upon deletion to remove any pending approval status.
    rafaucau committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6596569 View commit details
    Browse the repository at this point in the history
  2. fix: Implement PostWasUnapproved event for all unapproved posts, hidi…

    …ng discussions for unapproved initial posts
    
    Introduces the PostWasUnapproved event, fired upon every post unapproval. Specifically, when the unapproved post is the initial post of a discussion, this event also hides the entire discussion. This change ensures that unapproved initial posts do not leave their discussions visible on the forum.
    rafaucau committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3bbd1f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Revert "fix: Implement PostWasUnapproved event for all unapproved pos…

    …ts, hiding discussions for unapproved initial posts"
    
    This reverts commit 3bbd1f7.
    rafaucau committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d21770f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cd61c7 View commit details
    Browse the repository at this point in the history
  3. style: fix code formatting

    rafaucau committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    905a7b4 View commit details
    Browse the repository at this point in the history