Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix(Mentions): allow renderer to be used without context #3953

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[1.x] fix(Mentions): allow renderer to be used without context #3953

merged 2 commits into from
Jan 10, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Jan 9, 2024

Changes proposed in this pull request:
Allow post mentions to be used without context. As far as I understand, the same thing has already been done for user mentions in the past:

Reviewers should focus on:
Focus if this PR introduces regression in other parts of the code. I'll also have a quick look and see if I can quickly create a test which tests this.

Screenshot
Not applicable

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title fix(Mentions): allow rendered to be used without context fix(Mentions): allow renderer to be used without context Jan 9, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review January 9, 2024 12:49
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner January 9, 2024 12:49
@DavideIadeluca DavideIadeluca changed the title fix(Mentions): allow renderer to be used without context [1.x] fix(Mentions): allow renderer to be used without context Jan 9, 2024
@imorland
Copy link
Member

Looks good to me @DavideIadeluca thanks for putting this together!

@imorland imorland merged commit 8205ae5 into flarum:1.x Jan 10, 2024
273 checks passed
@DavideIadeluca DavideIadeluca deleted the di/fix-post-mentions-formatter branch January 10, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants