Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add frontend tests #3991

Merged
merged 12 commits into from
Sep 28, 2024
Merged

test: add frontend tests #3991

merged 12 commits into from
Sep 28, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 18, 2024

Fixes #3990

Changes proposed in this pull request:
Adds some minimal frontend tests to more easily catch introduced issues. These are kept minimal so as not to hamper future development work with having to constantly update tests.

  • Gonna need to add the Jest infra to the CLI + document how one can write a frontend test in Flarum, so info on that will be included in a follow up docs PR.

Screenshot
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner May 18, 2024 14:23
@SychO9 SychO9 self-assigned this May 18, 2024
# Conflicts:
#	framework/core/js/tests/unit/common/GambitManager.test.ts
#	js-packages/jest-config/setup-env.js
@SychO9 SychO9 added this to the 2.0 milestone Sep 28, 2024
@SychO9 SychO9 merged commit 257be2b into 2.x Sep 28, 2024
25 checks passed
@SychO9 SychO9 deleted the sm/frontend-tests branch September 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend tests
1 participant