Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] [extensibility] Add (some) missing shims #4027

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

DavideIadeluca
Copy link
Contributor

Fixes #0000

Changes proposed in this pull request:
Add some missing Typescript Shims

Reviewers should focus on:
I only added some of the lower hanging fruits, which are most likely to be used in third-party extensions and don't require a TS refactor of existing code. Some of the work on this has already been done on the 2.x branch.

Is this PR something that's already valuable enough to the ecosystem, or would you prefer a more thorough PR which aims to add everything possible?

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland added this to the 1.8.6 milestone Sep 30, 2024
@imorland imorland marked this pull request as ready for review October 2, 2024 10:50
@imorland imorland requested a review from a team as a code owner October 2, 2024 10:50
@imorland imorland added javascript Pull requests that update Javascript code type/extensibility labels Oct 2, 2024
@imorland imorland changed the title Add missing shims [1.x] [extensibility] Add (some) missing shims Oct 2, 2024
@imorland imorland merged commit 88f182c into flarum:1.x Oct 2, 2024
274 checks passed
@imorland imorland deleted the di/shims branch October 2, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants