Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: messages extension #4028

Merged
merged 25 commits into from
Sep 28, 2024
Merged

feat: messages extension #4028

merged 25 commits into from
Sep 28, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Sep 27, 2024

Part of the roadmap

Changes proposed in this pull request:

  • Adds a new basic messaging extension.
  • The models were named Dialog and DialogMessage to prevent conflicts with existing ecosystem messaging extensions that have already claimed the Conversation and Message names.
  • Most of the JS side components (Dropdown, Page) are lazy loaded.
  • A number of minor JS changes had to be made to other extensions (like tags) to allow reusing certain behavior.
  • The notifications in core had to be changed to allow having email-only notifications, as the notification for a message received does not need to be duplicated to alerts as well.

Screenshot
image
image
image
image
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 and others added 22 commits September 14, 2024 14:11
# Conflicts:
#	framework/core/js/dist-typings/common/states/PageState.d.ts
#	framework/core/js/dist-typings/common/states/PaginatedListState.d.ts
#	framework/core/js/dist-typings/forum/states/DiscussionListState.d.ts
#	framework/core/js/src/common/states/PaginatedListState.ts
#	framework/core/js/src/forum/components/CommentPost.js
#	framework/core/less/common/root.less
# Conflicts:
#	framework/core/js/src/forum/components/PostMeta.js
@SychO9 SychO9 added this to the 2.0 milestone Sep 27, 2024
@SychO9 SychO9 self-assigned this Sep 27, 2024
@SychO9 SychO9 requested a review from a team as a code owner September 27, 2024 14:16
@SychO9 SychO9 changed the title feat: private messages feat: messages Sep 27, 2024
@SychO9 SychO9 changed the title feat: messages feat: messages extensions Sep 27, 2024
@SychO9 SychO9 changed the title feat: messages extensions feat: messages extension Sep 27, 2024
# Conflicts:
#	framework/core/less/common/root.less
@SychO9 SychO9 merged commit b74ecbf into 2.x Sep 28, 2024
23 of 24 checks passed
@SychO9 SychO9 deleted the sm/messages branch September 28, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants