Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] [QOL] chore: point fontawesome links at v5 free #4038

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

imorland
Copy link
Member

Changes proposed in this pull request:
Backport of #4036 to correctly link to FontAwesome 5 free.

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland added type/cleanup javascript Pull requests that update Javascript code labels Sep 29, 2024
@imorland imorland added this to the 1.8.6 milestone Sep 29, 2024
@imorland imorland requested a review from a team as a code owner September 29, 2024 07:30
@imorland imorland merged commit 3743bc0 into 1.x Sep 29, 2024
314 checks passed
@imorland imorland deleted the im/fontawesome-link branch September 29, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant