Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] [extensibility] refactor(core): improve extensibility of DiscussionPage #4046

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Sep 30, 2024

Fixes #0000

Changes proposed in this pull request:
Improve extensibility in the frontend to allow third-party extensions to more easily customize this component.

Reviewers should focus on:

  • Verify that the backwards compatibility is working as expected. The DOM must be exactly the same.
  • A subset of those extensibility improvements could be used for 2.x while considering the <PageStructure/>. Opinions on "forward-porting" that?

Screenshot
No differences

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title [1.x] [extensibility] refactor(core): improve extensibility of DiscussionPage [1.x] [extensibility] refactor(core): improve extensibility of DiscussionPage Sep 30, 2024
@imorland imorland added this to the 1.8.6 milestone Sep 30, 2024
@imorland imorland added javascript Pull requests that update Javascript code type/extensibility labels Sep 30, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review September 30, 2024 08:31
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner September 30, 2024 08:31
@imorland imorland merged commit 4912a2e into flarum:1.x Sep 30, 2024
274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants