Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Migration: js to tsx] HeaderPrimary.js converted to HeaderPrimary.tsx #4052

Merged
merged 3 commits into from
Oct 2, 2024
Merged

[Migration: js to tsx] HeaderPrimary.js converted to HeaderPrimary.tsx #4052

merged 3 commits into from
Oct 2, 2024

Conversation

ksvijayan06
Copy link
Contributor

@ksvijayan06 ksvijayan06 commented Oct 1, 2024 •
edited
Loading

Fixes #3533

Changes proposed in this pull request: Convert core JS to Typescript

Reviewers should focus on: Javascript code has been re-written in Typescript language

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@ksvijayan06 ksvijayan06 requested a review from a team as a code owner October 1, 2024 15:56
SychO9
SychO9 requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

framework/core/js/src/forum/components/HeaderPrimary.tsx Outdated Show resolved Hide resolved
@SychO9 SychO9 merged commit 4291918 into flarum:2.x Oct 2, 2024
18 checks passed
@SychO9 SychO9 added this to the 2.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
type/cleanup
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Convert core JS to Typescript
2 participants
@ksvijayan06 @SychO9