Allows multiple measurements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Sep 27, 2024
| for _, v := range validators { | ||
| if !v.OID().Equal(validators[0].OID()) { | ||
| // This is not an error! This is a bug! | ||
| panic("validators with mismatching OIDs passed in!") |
There was a problem hiding this comment.
Would returning an err be better here?
There was a problem hiding this comment.
I strongly prefer to panic in this case -- this is not an user error.
There was a problem hiding this comment.
it's fine with me in this case :)
curious why tho. shouldn't generally libraries or imported code never panic but always return an error, because that allows the application to decide what to show and how to handle?
There was a problem hiding this comment.
Yeah there's something to what you are saying.
In this specific scenario this is more a part of the application rather than a library
|
LGTM |
fnerdman
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.