Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fee refunds: document new fee refund by recipient RPCs #582

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

ryanschneider
Copy link
Contributor

@ryanschneider ryanschneider commented Sep 30, 2024

This PR documents the flashbots_getFeeRefundTotalsByRecipient and flashbots_getFeeRefundsByRecipient RPCs, as well it adds details about the on-chain txs we've sent refunds through.

As noted in my screenshot below, at least at my resolution the flashbots_getFeeRefundTotalsByRecipient RPC name is one character too long to fit on a single line in the right-hand RPC TOC. I tried to find where we control the width of that flex box element but I couldn't find any explicit reference to it, but I also have very little frontend dev experience so maybe someone w/ more familiarity with our docs code can suggest where to tweak?

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flashbots-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 7:25pm

@ryanschneider ryanschneider changed the title fee refunds: document new fee refund by receipient RPCs fee refunds: document new fee refund by recipient RPCs Sep 30, 2024
@ryanschneider
Copy link
Contributor Author

Hmm I wonder if we can adjust the sidebar size somewhere?

image

Copy link
Collaborator

@sketsdever sketsdever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
@ryanschneider
Copy link
Contributor Author

@sketsdever I think I addressed all your comments, please take another look!

Copy link
Collaborator

@sketsdever sketsdever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final tweaks to copy and one ask to change the name of a field

docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@sketsdever sketsdever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! One tiny nit that's not blocking.

docs/flashbots-auction/advanced/rpc-endpoint.mdx Outdated Show resolved Hide resolved
@ryanschneider ryanschneider merged commit 0561a08 into main Oct 1, 2024
3 checks passed
@ryanschneider ryanschneider deleted the fee-refunds-by-recipient branch October 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants