-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fee refunds: document new fee refund by recipient RPCs #582
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments!
@sketsdever I think I addressed all your comments, please take another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final tweaks to copy and one ask to change the name of a field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! One tiny nit that's not blocking.
This PR documents the
flashbots_getFeeRefundTotalsByRecipient
andflashbots_getFeeRefundsByRecipient
RPCs, as well it adds details about the on-chain txs we've sent refunds through.As noted in my screenshot below, at least at my resolution the
flashbots_getFeeRefundTotalsByRecipient
RPC name is one character too long to fit on a single line in the right-hand RPC TOC. I tried to find where we control the width of that flex box element but I couldn't find any explicit reference to it, but I also have very little frontend dev experience so maybe someone w/ more familiarity with our docs code can suggest where to tweak?