[code health] Refactor fee recipient check in handleSubmitNewBlock
#479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Pull the fee recipient check into an independent function. This is the first PR in a set to refactor the
handleSubmitNewBlock
function to be more modular. This increases readability and unit-testability of the components that make up a block submission, and allows for this logic to be reused in other block submission paths.⛱ Motivation and Context
In order to make #466 easier to review, we want to refactor some of the block submission path to be reusable for v2 optimistic submissions. This has the nice added benefit of improving the code health of the relay as a whole, which is a nice perk :-)
📚 References
https://notes.ethereum.org/@mikeneuder/optimistic-v2 describes the status of v2 optimistic relaying.
✅ I have run these commands
make lint
make test-race
go mod tidy
CONTRIBUTING.md