Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deneb compatibility to optimistic types #615

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

avalonche
Copy link
Collaborator

πŸ“ Summary

The optimistic v2 types were capella specific and did not support Deneb. This PR adds deneb support for the optimistic v2 path.

β›± Motivation and Context

Enabling optimistic features on the boost-relay as it is a feature implemented by many relays.

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 45.33898% with 129 lines in your changes missing coverage. Please review.

Project coverage is 31.27%. Comparing base (d61f228) to head (4e02e4b).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
common/types.go 50.00% 62 Missing and 24 partials ⚠️
common/types_spec.go 0.00% 31 Missing ⚠️
common/utils.go 63.63% 8 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   30.43%   31.27%   +0.83%     
==========================================
  Files          41       41              
  Lines        6275     6399     +124     
==========================================
+ Hits         1910     2001      +91     
- Misses       4118     4143      +25     
- Partials      247      255       +8     
Flag Coverage Ξ”
unittests 31.27% <45.33%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants