Root hash thread pool, new trie benches. #404
Merged
+316
−77,322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds a new, configurable thread pool used for root hash with custom thread names * refactors sparse trie benches and tests to use gzip files * adds more benches for real tries with focus on p99 latency
Benchmark results for
|
| Date (UTC) | 2025-02-05T16:27:35+00:00 |
| Commit | 6b7a62c17834b2b2e549507d44eb8f5c73d19187 |
| Base SHA | eb2784e73a428b02b4c8a46577ddf7bfe397a1c4 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_clone | 17.38% | Performance has degraded. |
| MEV-Boost SubmitBlock serialization/JSON encoding | -30.90% | Performance has improved. |
| reference_trie_insert_and_hash_3000 | -4.88% | Performance has improved. |
ZanCorDX
requested changes
Feb 5, 2025
There was a problem hiding this comment.
StateProviderFactory::root_hasher should not have "thread_pool: Option", since it's for a specific implementation.
It should be in StateProviderFactoryFromProviderFactory/StateProviderFactoryFromRethProvider the same way we hide the root_hash_config from the roothash users (maybe StateProviderFactoryFromRethProvider/StateProviderFactoryFromProviderFactory need a refactoring?).
|
good point, I moved it to root hash config (now called context) since its begins from config file and its being copied from there. |
ZanCorDX
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
I was experimenting with thread affinity and improved eth sparse trie along the way. Affinity does not appear to give boost in real builder so its not here. We should revisit it in the future.
✅ I have completed the following steps:
make lintmake test