Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/login1: initial commit #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pkg/login1: initial commit #112

wants to merge 1 commit into from

Conversation

invidian
Copy link
Member

@invidian invidian commented Jan 6, 2022

This commit adds login1 package, which is a small subset of
github.com/coreos/go-systemd/v22/login1 package with ability to use
shared D-Bus connection and with proper error handling for Reboot method
call, which is not yet provided by the upstream.

The idea is to use this package in favor of github.com/coreos/go-systemd
in agent code responsible for rebooting the node. However, this requires
tests in agent code, so it will be done in the next step.

See coreos/go-systemd#387 for more details.

Signed-off-by: Mateusz Gozdek [email protected]

Base automatically changed from invidian/dbus-improvements to master January 6, 2022 13:38
@invidian invidian force-pushed the invidian/login1 branch 3 times, most recently from 0d29d06 to d67e745 Compare January 6, 2022 14:26
@invidian
Copy link
Member Author

invidian commented Jan 6, 2022

This PR will become relevant once we have enough test code for agent to add checking for reboot errors.

This commit adds login1 package, which is a small subset of
github.com/coreos/go-systemd/v22/login1 package with ability to use
shared D-Bus connection and with proper error handling for Reboot method
call, which is not yet provided by the upstream.

The idea is to use this package in favor of github.com/coreos/go-systemd
in agent code responsible for rebooting the node. However, this requires
tests in agent code, so it will be done in the next step.

See coreos/go-systemd#387 for more details.

Signed-off-by: Mateusz Gozdek <[email protected]>
@invidian
Copy link
Member Author

Attempt to submit this code upstream: coreos/go-systemd#390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant