Prefer wayland over X11

[jsparber]

Always try to use wayland and fallback to X11 only when wayland isn't available.

This fixes the "Unvanquished is potentially unsafe" warning on flathub.

[flathubbot]

Started test build 112245

[flathubbot]

Build 112245 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95059/net.unvanquished.Unvanquished.flatpakref

[necessarily-equal]

Hello! Thanks you for your interest.

Last I checked, we still had some problems with the wayland display protocol. Although they do not seem to be critical, I think we should at least fix some of them before we switch. Those issues are tracked in DaemonEngine/Daemon#482 (I've just updated it a bit).

The most annoying issues would be Unvanquished/Unvanquished#1887, and maybe the (alleged) framerate drop DaemonEngine/Daemon#484.

Most of these issues seem to need some triaging to check if they are still causing trouble, would you be willing to help on that? This means checking if the issues still exist, and if you experience those yourself 😃

[jsparber]

Not sure, how much time i have to look at this. I was mostly annoyed about the warning on flathub :)

[necessarily-equal]

I would also like to get rid of the warning, but before that I think it would be good to make sure it runs smoothly. I don't know how much you could play under wayland and on X11 as of now. Did you notice issues like lower frame rate or disappearing cursor when buying stuff in-game? Anything else? Part of the issue is that it is a bit under-tested, so having feedback from people on different distros, graphic drivers and compositors is valuable — so feedback welcome

…

On 5 April 2024 12:22:50 CEST, Julian Sparber ***@***.***> wrote: Not sure, how much time i have to look at this. I was mostly annoyed about the warning on flathub :) -- Reply to this email directly or view it on GitHub: #16 (comment) You are receiving this because you commented. Message ID: ***@***.***>

[necessarily-equal]

I tested on Wayland a bit while working on #17 and I still noticed the bug where in game, the cursor disappears on Wayland until it hoovers on top of a window. See Unvanquished/Unvanquished#1887 (comment) for more details on that bug.

For now I'd say X11 still works a little bit better, and is definitely better tested, so I didn't change the default just yet.

By the way for me this PR didn't work out of the box. To get the Wayland backend working at all when X11 was disabled, I had to pass SDL_VIDEODRIVER=wayland,x11 as an environment variable as well. This led me to notice another bug, fixed in 53c51d4