Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export mime icons and remove jack #286

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Export mime icons and remove jack #286

merged 2 commits into from
Dec 3, 2023

Conversation

hfiguiere
Copy link
Contributor

@hfiguiere hfiguiere commented Oct 16, 2023 •
edited
Loading

Export the mime icons so that the icons for the files in the mimetype shows.

also remove jack: pw-jack is in the runtime

@flathubbot
Copy link
Contributor

Started test build 74020

@flathubbot
Copy link
Contributor

Build 74020 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/56669/org.kde.kdenlive.flatpakref

@hfiguiere hfiguiere marked this pull request as draft October 16, 2023 21:05
@flathubbot
Copy link
Contributor

Started test build 74240

@flathubbot
Copy link
Contributor

Build 74240 failed

@flathubbot
Copy link
Contributor

Started test build 74241

@flathubbot
Copy link
Contributor

Build 74241 failed

@flathubbot
Copy link
Contributor

Started test build 74242

@flathubbot
Copy link
Contributor

Build 74242 failed

@flathubbot
Copy link
Contributor

Started test build 74245

@hfiguiere hfiguiere changed the title Export mime icons Export mime icons and remove jack Oct 17, 2023
@flathubbot
Copy link
Contributor

Build 74245 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/56892/org.kde.kdenlive.flatpakref

@flathubbot
Copy link
Contributor

Started test build 79861

@hfiguiere hfiguiere marked this pull request as ready for review November 8, 2023 01:39
@flathubbot
Copy link
Contributor

Build 79861 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/62477/org.kde.kdenlive.flatpakref

@hfiguiere
Copy link
Contributor Author

it works.

@jlskuz
Copy link
Collaborator

jlskuz commented Nov 8, 2023

Makes sense to me.

I do not understand how the mime icon fix works in detail. Is this something we can fix upstream?

@hfiguiere
Copy link
Contributor Author

icons must be renamed to be exported (thus availble), and then the mime type file should reference them.

I have a pending change for flatpak-builder that would do it with just a few lines:
flatpak/flatpak-builder#567

@flathubbot
Copy link
Contributor

Started test build 82855

@flathubbot
Copy link
Contributor

Build 82855 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65489/org.kde.kdenlive.flatpakref

@hfiguiere
Copy link
Contributor Author

rebased, again.

@flathubbot
Copy link
Contributor

Started test build 83303

@flathubbot
Copy link
Contributor

Build 83303 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65937/org.kde.kdenlive.flatpakref

@hfiguiere
Copy link
Contributor Author

rebased, again.

@flathubbot
Copy link
Contributor

Started test build 84979

@flathubbot
Copy link
Contributor

Build 84979 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/67630/org.kde.kdenlive.flatpakref

@hfiguiere hfiguiere requested a review from tsdgeos December 3, 2023 19:02
@hfiguiere
Copy link
Contributor Author

Rebased, one more time.

@flathubbot
Copy link
Contributor

Started test build 85278

@flathubbot
Copy link
Contributor

Build 85278 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/67927/org.kde.kdenlive.flatpakref

@jlskuz jlskuz merged commit d7faa8b into master Dec 3, 2023
@hfiguiere hfiguiere deleted the mime-icons branch December 3, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsdgeos tsdgeos Awaiting requested review from tsdgeos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hfiguiere @flathubbot @jlskuz