Allows GNOME users to browse photos on network shares #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permission is needed by GNOME users to be able to browse photos on network shares (SMB, FTP, ...)
hfiguiere
reviewed
May 26, 2022
| @@ -10,7 +10,8 @@ | |||
| "--socket=wayland", | |||
| "--socket=pulseaudio", | |||
| "--filesystem=home", | |||
| "--filesystem=/media" | |||
| "--filesystem=/media", | |||
| "--filesystem=xdg-run/gvfs" | |||
There was a problem hiding this comment.
don't you need the dbus talk-name too for gvfs ?
There was a problem hiding this comment.
Sorry I'm not sure what do you mean. Giving Nomacs permissions to access "xdg-run/gvfs" should be enough, or not?
For me it works, and I'm able to browse pictures on network shares.
I'm no expert on this matter, what should "dbus talk-name" do?
|
Started test build 93404 |
|
Build 93404 successful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Nomacs on GNOME, you are able to open file from network share, but you won't be able to browse photos within the Nomacs.
To xdg-run/gvfs are mounted SAMBA shares, FTP shares, Google drive, etc..