Add SDL_gfx module #166
Add SDL_gfx module #166
Conversation
SDL/SDL_gfx-2.0.25.json
Outdated
| "i386": { | ||
| "config-opts": [ | ||
| "--enable-mmx" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
| "i386": { | |
| "config-opts": [ | |
| "--enable-mmx" | |
| ] | |
| }, |
arch is no longer supported.
There was a problem hiding this comment.
I would actually remove the disable-mmx from config opts and just add it for aarch64. I feels less convoluted.
and I would submit a patch upstream to actually properly detect architectures.
There was a problem hiding this comment.
I understand your point. FWIW I did it this way around because the --enable-mmx code will fail to compile on any non-x86 platform, so when someone comes along and adds RISC-V to Flathub, another arch-specific block would need to be added.
There was a problem hiding this comment.
when it happens, we'll see. Maybe by that time they'll have apply the patch I recommend submitting.
There was a problem hiding this comment.
I have to say I am not filled with enthusiasm at the prospect of sending a patch upstream. SDL_gfx (this one) appears to be abandoned; SDL2_gfx, its SDL2 successor, only marginally less so.
|
For HyperRogue: flathub/com.roguetemple.HyperRogue#1 |
This requires special care and feeding to build on aarch64, which I borrowed from org.manaplus.ManaPlus when org.tuxpaint.Tuxpaint gained a dependency on this library. I suspect (without proof) that this library is one of the reasons that the other existing user of SDL_gfx on Flathub, com.roguetemple.HyperRogue, is not built for aarch64.
| "aarch64": { | ||
| "//": "Code assumes that if __GNUC__ is defined and MMX is enabled, then x86-specific mmintrin.h is available", | ||
| "config-opts": [ | ||
| "--disable-static", |
There was a problem hiding this comment.
AFAIK the config-opts are cumulative.
|
I'd like somebody added to CODEOWNERS if they are willing. |
|
this doesn't seem to be very hard to maintain, is there any need/want for this to be merged still? I could look into maintaining it if yes. |
This requires special care and feeding to build on aarch64, which I
borrowed from org.manaplus.ManaPlus when org.tuxpaint.Tuxpaint gained a
dependency on this library.
I suspect (without proof) that this library is one of the reasons that
the other existing user of SDL_gfx on Flathub,
com.roguetemple.HyperRogue, is not built for aarch64.