Use GnuTLS as the crypto backend for libsecret #294
Conversation
GnuTLS is present in the base Freedesktop platform & SDK, this is also what Fedora has been shipping with as of a couple months ago. https://src.fedoraproject.org/rpms/libsecret/c/a858664cc30cb9103a9818cdb97a20879ab8cfb5
|
This means that |
|
It's at least not exiting when it can't find the required version of gnutls 3.8.2 |
Actually this may be advantage here otherwise it will stop working with fdsdk 22.08 which as noted won't have relevant gnutls. Fedora commit says it's to have one less lib loaded in memory - I wonder if this is really worth it. The fact it makes libsecret depend on minor runtime release isn't great. |
|
As @Erick555 noted in #freedesktop-sdk, updating gnutls to 3.8.2 in 23.08 branch of freedesktop-sdk will break forward ABI guarantees. So this needs to wait until 24.08 comes out this October or November. The update to Or even if the update lands in freedesktop-sdk, libsecret cannot start depending on it in the 22.08 and 23.08 cycle. |
It just disables all crypto: https://gitlab.gnome.org/GNOME/libsecret/-/blob/master/meson.build?ref_type=heads#L51-62 |
|
That's worse. Then it can't land in any case, until every supported runtime has the dependency. |
|
Just to be clear, if you disable crypto it only means apps will use the dbus backend rather than the secrets portal, it does not disable encryption at the library level. Having said that, there is no migration path between the two backends, from the app pov secrets existing secrets would just not be there anymore. |
|
i think the solution is to update runtime not force a behavior |
|
If there is no migration path, then this needs to be a separate manifest Those wanting to use that one can explicitly add it after assessing it for their app. |
|
Libsecret was added to freedesktop-sdk for 25.08 (default build using gcrypt backend as it will replace this shared module). The current shared modules has no maintainer and will most likely be removed once 25.08 is out. Chromium and Electron does not work with the default build, they need the DBus backends. I switched chromium to that already flathub/org.chromium.Chromium.BaseApp@3937abe Electron baseapp will be switched to that in the 25.08 branch as it is a breaking change. These should cover all the needs of majority of the apps. |
No description provided.