-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promisify prompt.get #196
promisify prompt.get #196
Conversation
8e1ac94
to
34658ba
Compare
I'm not really active on this project any more, so I'm a little hesitant to merge the PR when the build isn't passing. |
Ah, I initially put an arrow callback
then I changed it to a function for node 0.12 34658ba The CI should pass, I just don't manage to restart the CI build It'd be really great if you could merge it, I'm sure many other users would benefit from this promise-style Thanks in advance for your time |
Ah, I forgot one arrow fn (there were 2, I changed only 1), thanks CI It should pass now, sorry |
The error now https://travis-ci.org/flatiron/prompt/jobs/657864911#L322 has nothing to do with this PR |
|
a94cf28
to
52fa1b6
Compare
c72a1bd
to
0f554ce
Compare
Thanks @gangstead , do you have npm push access by any chance? If not, https://www.npmjs.com/package/prompt shows @indexzero and @jcrugzz as collaborators, if they can do a Thanks guys |
Nope. Sorry.
…On Thu, Mar 5, 2020 at 7:37 AM Cyril Auburtin ***@***.***> wrote:
do you have npm push access by any chance?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#196?email_source=notifications&email_token=AAEA3EDY3DEBUO36AMNNEHDRF6TJXA5CNFSM4K74BT4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN5IWDI#issuecomment-595233549>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEA3EEBISMIKYJFCO6BGGLRF6TJXANCNFSM4K74BT4A>
.
|
@indexzero Hey, could you please, when you've a minute, do a We added a helpful promisified |
Yeah this would really be nice. |
Can any one of the npm collaborators @jcrugzz @indutny @indexzero do something please? we need to sync this new updates on npm |
@gangstead Hi, could you check this very small PR?
It just promisifies
prompt.get
(if no callback passed)it'll help for #170
We have to do
every time we use prompt, so that PR would be cool