Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 support - with suggested changes #71

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomhog
Copy link

@tomhog tomhog commented Nov 17, 2021

I've taken the this.response._headerNames part out of the catch statement

Xmader and others added 3 commits June 4, 2019 01:34
@k2s
Copy link

k2s commented Dec 19, 2021

Call this.response._headerNames shows the same deprecation warning.
My fix proposal is:

    if (this.response.getHeaderNames) {
      this._headers = this.response.getHeaders() || {};
    } else {
      this._headers = this.response._headers || {};
      // Patch to node core
      this.response._headerNames = this.response._headerNames || {};
    }

@lamweili
Copy link

lamweili commented Jan 14, 2024

@darrendatbui has made the changes in PR #77 which superseded this PR.
Let's continue there and close this PR.

This has been superseded by PR #64.
This PR can be closed.

Ping @indexzero @jcrugzz

@lamweili lamweili mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants