Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrachh Hello, I have added make.inc.nag for NAG Fortran compiler and made non-essential but some changes in the source code.
My local machine works on Ubuntu 20.04.6 LTS with a standard x86-64 architecture.
Both
make install
andmake test
are successful using gfortran-9 with the changes.(The paths of included text files need to be changed back to the previously set relative paths in src/Helmholtz/hwts3e.f to use gfortran, though.)
The current results obtained using the NAG compiler are the following.
make install
succeeds in creating the static library but fails in dynamic link library.make test
passes all tests except for helm3d_mps.I would appreciate it if you could look at the changes of this pull request at your convenience.