Make cufinufft compiles with CUDA 12 on Windows #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86475ea.
|
I guess we could get rid of exporting all symbols in cufinufft and make a CUFINUFFT_EXPORT macro. |
lu1and10
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Good to know M_1_2PI was renamed to INV_2PI.
Should devel/foldrescale_perf.cpp and devel/foldrescale_perf2.cpp also change to INV_2PI?
There was a problem hiding this comment.
Yes, but as they are not included in cmake I did not spot the compilation error.
lu1and10
reviewed
Jan 27, 2025
| @@ -16,7 +16,6 @@ | |||
|
|
|||
| // convenient private finufft internals | |||
| #include <finufft/finufft_core.h> | |||
| #include <finufft/utils.h> | |||
There was a problem hiding this comment.
In this test_defs.h, on windows it has dependency on rand_r defined in finufft_utils.hpp. For linux/Mac, rand_r is included in cstdlib in this header.
There was a problem hiding this comment.
Yes, I just moved it into the test folder. As it is only needed in tests.
lu1and10
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a bit of cleanup for small measure.
Closes: #577
Fixes: #589 #441 #578