Make onHelp optional

flatironinstitute · Jul 26, 2024 · 2bf3729 · 2bf3729
1 parent 805ca1b
commit 2bf3729
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/gui/src/app/Scripting/Analysis/AnalysisPyWindow.tsx b/gui/src/app/Scripting/Analysis/AnalysisPyWindow.tsx
@@ -87,7 +87,6 @@ const AnalysisPyWindow: FunctionComponent<AnalysisWindowProps> = ({
       onRun={handleRun}
       runnable={runnable}
       notRunnableReason={notRunnableReason}
-      onHelp={() => {}}
       imagesRef={imagesRef}
       consoleRef={consoleRef}
       contentOnEmpty={contentOnEmpty}

diff --git a/gui/src/app/Scripting/Analysis/AnalysisRWindow.tsx b/gui/src/app/Scripting/Analysis/AnalysisRWindow.tsx
@@ -62,7 +62,6 @@ const AnalysisRWindow: FunctionComponent<AnalysisWindowProps> = ({
       onRun={handleRun}
       runnable={runnable}
       notRunnableReason={notRunnableReason}
-      onHelp={() => {}}
       imagesRef={imagesRef}
       consoleRef={consoleRef}
       contentOnEmpty={contentOnEmpty}

diff --git a/gui/src/app/Scripting/ScriptEditor.tsx b/gui/src/app/Scripting/ScriptEditor.tsx
@@ -23,7 +23,7 @@ export type ScriptEditorProps = {
   onRun: (code: string) => void;
   runnable: boolean;
   notRunnableReason?: string;
-  onHelp: () => void;
+  onHelp?: () => void;
   contentOnEmpty?: string | HTMLSpanElement;
   consoleRef: RefObject<HTMLDivElement>;
 };
@@ -113,16 +113,18 @@ const makeToolbar = (o: {
   runnable: boolean;
   notRunnableReason?: string;
   onRun: () => void;
-  onHelp: () => void;
+  onHelp?: () => void;
 }): ToolbarItem[] => {
   const { status, onRun, runnable, onHelp, name } = o;
   const ret: ToolbarItem[] = [];
-  ret.push({
-    type: "button",
-    tooltip: "Help",
-    icon: <Help />,
-    onClick: onHelp,
-  });
+  if (onHelp !== undefined) {
+    ret.push({
+      type: "button",
+      tooltip: "Help",
+      icon: <Help />,
+      onClick: onHelp,
+    });
+  }
   if (runnable) {
     ret.push({
       type: "button",