Remove unnecessary json parse, pass data as string

flatironinstitute · Oct 30, 2024 · 5df89a5 · 5df89a5
1 parent 79e1111
commit 5df89a5
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 14 deletions.
diff --git a/gui/src/app/FileEditor/TextEditor.tsx b/gui/src/app/FileEditor/TextEditor.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { Editor, loader, useMonaco } from "@monaco-editor/react";
 import { useTheme } from "@mui/material/styles";
 

diff --git a/gui/src/app/RunPanel/RunPanel.tsx b/gui/src/app/RunPanel/RunPanel.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { FunctionComponent, useCallback, useContext, useMemo } from "react";
 
 import Button from "@mui/material/Button";
@@ -14,7 +13,7 @@ import Tooltip from "@mui/material/Tooltip";
 type RunPanelProps = {
   sampler?: StanSampler;
   latestRun: StanRun;
-  data: any | undefined;
+  data: string;
   dataIsSaved: boolean;
   samplingOpts: SamplingOpts;
 };

diff --git a/gui/src/app/components/TabWidget.tsx b/gui/src/app/components/TabWidget.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import Box from "@mui/material/Box";
 import Tab from "@mui/material/Tab";
 import Tabs from "@mui/material/Tabs";

diff --git a/gui/src/app/pages/HomePage/SamplingWindow/SamplingWindow.tsx b/gui/src/app/pages/HomePage/SamplingWindow/SamplingWindow.tsx
@@ -1,4 +1,4 @@
-import { FunctionComponent, useCallback, useContext, useMemo } from "react";
+import { FunctionComponent, useCallback, useContext } from "react";
 
 import Box from "@mui/material/Box";
 import Divider from "@mui/material/Divider";
@@ -23,13 +23,6 @@ type SamplingWindowProps = {
 
 const SamplingWindow: FunctionComponent<SamplingWindowProps> = () => {
   const { data, update } = useContext(ProjectContext);
-  const parsedData = useMemo(() => {
-    try {
-      return JSON.parse(data.dataFileContent);
-    } catch (e) {
-      return "";
-    }
-  }, [data.dataFileContent]);
 
   const setSamplingOpts = useCallback(
     (opts: SamplingOpts) => {
@@ -55,7 +48,7 @@ const SamplingWindow: FunctionComponent<SamplingWindowProps> = () => {
           <RunPanel
             sampler={sampler}
             latestRun={latestRun}
-            data={parsedData}
+            data={data.dataFileContent}
             dataIsSaved={!modelHasUnsavedDataFileChanges(data)}
             samplingOpts={data.samplingOpts}
           />

diff --git a/gui/src/main.tsx b/gui/src/main.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import * as ReactDOM from "react-dom/client";
 
 import App from "./app/App";