Merge pull request #141 from flatironinstitute/dont-save-empty

Don't save empty files to zip
flatironinstitute · Jul 23, 2024 · 692b66a · 692b66a
2 parents 0f7c84d + b311caa
commit 692b66a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/gui/src/app/Project/ProjectSerialization.ts b/gui/src/app/Project/ProjectSerialization.ts
@@ -60,7 +60,9 @@ export const serializeAsZip = async (
     throw new Error("Error creating folder in zip file");
   }
   Object.entries(fileManifest).forEach(([name, content]) => {
-    folder.file(name, content);
+    if (content.trim() !== "") {
+      folder.file(name, content);
+    }
   });
   const zipBlob = await zip.generateAsync({ type: "blob" });
 

diff --git a/gui/src/app/pages/HomePage/SaveProjectWindow.tsx b/gui/src/app/pages/HomePage/SaveProjectWindow.tsx
@@ -1,6 +1,6 @@
 import { FunctionComponent, useCallback, useContext, useState } from "react";
 
-import { serializeAsZip } from "@SpCore//ProjectSerialization";
+import { serializeAsZip } from "@SpCore/ProjectSerialization";
 import { FileRegistry, mapModelToFileManifest } from "@SpCore/FileMapping";
 import { ProjectContext } from "@SpCore/ProjectContextProvider";
 import saveAsGitHubGist from "@SpCore/gists/saveAsGitHubGist";
@@ -35,12 +35,15 @@ const SaveProjectWindow: FunctionComponent<SaveProjectWindowProps> = ({
               />
             </td>
           </tr>
-          {Object.entries(fileManifest).map(([name, content], i) => (
-            <tr key={i}>
-              <td>{name}</td>
-              <td>{content.length} bytes</td>
-            </tr>
-          ))}
+          {Object.entries(fileManifest).map(
+            ([name, content], i) =>
+              content.trim() !== "" && (
+                <tr key={i}>
+                  <td>{name}</td>
+                  <td>{content.length} bytes</td>
+                </tr>
+              ),
+          )}
         </tbody>
       </table>
       <div>&nbsp;</div>