Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow partial parse for SamplingOpts #125

Closed
jsoules opened this issue Jul 9, 2024 · 1 comment · Fixed by #147
Closed

Allow partial parse for SamplingOpts #125

jsoules opened this issue Jul 9, 2024 · 1 comment · Fixed by #147

Comments

@jsoules
Copy link
Collaborator

jsoules commented Jul 9, 2024

As mentioned in comments for PR #124

Currently we insist on a full parse for a SamplingOpts object to be considered successfully deserialized. Going forward it will likely be more resilient and flexible to populate any missing values with defaults instead.
@WardBrian
Copy link
Collaborator

In particular, this issue should be considered a blocker for adding any new entries to SamplingOptions. Before that point, it's just a "nice to have"

@WardBrian WardBrian mentioned this issue Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse partial sampling opts, fill remaining keys with defaults flatironinstitute/stan-playground
2 participants
@jsoules @WardBrian