Parse partial sampling opts, fill remaining keys with defaults #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoules
approved these changes
Jul 24, 2024
| @@ -33,13 +33,16 @@ const validateSamplingOpts = (x: SamplingOpts): boolean => { | |||
| if (naturalFields.some((f) => !Number.isInteger(f))) return false; | |||
| if (positiveFields.some((f) => f <= 0)) return false; | |||
| if (nonnegativeFields.some((f) => f < 0)) return false; | |||
|
|
|||
| if (Object.keys(x).length !== 5) return false; | |||
There was a problem hiding this comment.
Not sure I love hard-coding the 5; it isn't likely to be an issue in a serious way but I can see us tripping over this every time we change the number of potential sampling opts (which admittedly isn't going to be often).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125