Create templates in script editors #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
reviewed
Jul 25, 2024
jsoules
reviewed
Jul 25, 2024
Comment on lines
+90
to
+103
| const contentOnEmpty = useMemo(() => { | ||
| const spanElement = document.createElement("span"); | ||
| const t1 = document.createTextNode( | ||
| "Define a dictionary called data to update the data.json. ", | ||
| ); | ||
| const a1 = document.createElement("a"); | ||
| a1.onclick = () => { | ||
| setEditedFileContent(dataPyTemplate); | ||
| }; | ||
| a1.textContent = "Click here to generate an example"; | ||
| spanElement.appendChild(t1); | ||
| spanElement.appendChild(a1); | ||
| return spanElement; | ||
| }, [setEditedFileContent]); |
There was a problem hiding this comment.
Is it possible to do this as a React component? No worries if not, it just seems like it'd be more straightforward than having to assemble it manually.
There was a problem hiding this comment.
Would be nice, but I don't think it's possible.
There was a problem hiding this comment.
I just looked into a few options, all the supported ways of turning a JSX element into a actual DOM element are in react-dom/server and therefore don't persist the onClick in a meaningful way. Too bad
gui/src/app/pages/HomePage/DataGenerationWindow/DataRFileEditor.tsx
Outdated
Show resolved
Hide resolved
WardBrian
approved these changes
Jul 25, 2024
gui/src/app/pages/HomePage/DataGenerationWindow/DataRFileEditor.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #150
In data.py, data.R, analysis.py... if the editor is empty, there is a LINK text hint inviting click to generate template code.
We'll want to think about what the template code should be, and whether we want to somehow link to more thorough documentation.