webR: Support streaming output #175
Conversation
|
I tried it out on my machine and it's very smooth for the analysis.R example that we've been working with. It's really helpful to show the console progress during package loading. The usage also looks nice. Not sure how much you want me to review that new file. I believe it's doing the right thing, but I can take a closer look if you want. |
The only part I feel somewhat uncertain of is the async loop, but I think it is working, and it is based on their examples pretty heavily. Also, do you know if the useMemos I put in the call sites are actually valuable? |
The only thing I would suggest is to have a way to terminate that infinite loop when the useEffect gets closed. That would require passing in something like
In this case, useMemo is not needed since you are only using the individual components in the hook dependencies in useWebR. I think you should pass these arguments directly to useWebR() rather than making a separate variable webRArgs. |
|
Changes look good to me. |
| `webr::shim_install() | ||
| webr::canvas()`, |
There was a problem hiding this comment.
These might be a hair more legible if you throw them into a const somewhere with less indentation & give them a name.
| `if (typeof(data) != "list") { | ||
| stop("[stan-playground] data must be a list") | ||
| } | ||
| .SP_DATA <- jsonlite::toJSON(data, pretty = TRUE, auto_unbox = TRUE) | ||
| invisible(.SP_DATA)`, |
There was a problem hiding this comment.
These might be a hair more legible if you throw them into a const somewhere with less indentation & give them a name.
|
@jsoules I used the trick we've used elsewhere to put them in actual .R files so we even get nicer syntax highlighting in our editor now |
This uses some examples from the webR documentation to produce something that looks a lot more like the way we handle output in Python. In particular, outputs (both text and plots) will populate while the script is running, rather than at the end.
Because webR provides this via a async API, I had to use their pattern of a infinite (or at least not obviously terminating) async loop, which I find kind of strange. Getting this right required a bit of extra state management, but the end result is pretty nice to use.