Replace fi-sci modal with direct use of MUI component. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Once this gets merged (hopefully soon!). I will resolve conflicts with my 2 outstanding PRs. |
WardBrian
reviewed
Jul 31, 2024
gui/src/app/CompilationServerConnectionControl/ConfigureCompilationServerDialog.tsx
Show resolved
Hide resolved
gui/src/app/CompilationServerConnectionControl/ConfigureCompilationServerDialog.tsx
Show resolved
Hide resolved
WardBrian
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
@fi-sci/modal-windowin favor of modal dialog boxes more in line with the MUI standard & default look-and-feel. Functionality is unchanged.Additional changes include moving the content of the connection-configuration modal dialog to its own file, and adding a
ThemeProvidercomponent at the project root to fix a persistent known issue in MUI/Vite combinations (see mui/material-ui#31835). (I incidentally updated the versions ofMUIandIcons-Materialwhile attempting to address this bug, but I think this isn't super important--we can back out if desired.)The "CloseableDialog" component follows directly on the example from https://mui.com/material-ui/react-dialog/ (see "Customization").