Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help button to stan editor - open user guide #193

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

magland
Copy link
Collaborator

@magland magland commented Aug 1, 2024

Close #192

Add Help button to open Stan Users Guide
Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only thing to consider is making the help button the same blue color as the other icons in the toolbar--wasn't sure if the difference was intentional (to make it stand out) or not.

@magland
Copy link
Collaborator Author

magland commented Aug 1, 2024

Looks good to me. Only thing to consider is making the help button the same blue color as the other icons in the toolbar--wasn't sure if the difference was intentional (to make it stand out) or not.

I was just being consistent with the help buttons on the data script editors. If others have a preference it doesn't matter to me.

@WardBrian
Copy link
Collaborator

I think we can consider colors as part of #186, for now I agree matching the others is good

@WardBrian WardBrian merged commit 6fed1ea into main Aug 1, 2024
2 checks passed
@WardBrian WardBrian deleted the stan-editor-help-button branch August 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

links to Stan docs in app?
3 participants