Prevent running of model with non-parseable data.json. #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #226.
This PR makes the
handleRun
callback (defined inRunPanel.tsx
and used as a parameter to theCompiledRunPanel
component) nullable. The callback will beundefined
if thedata.json
does not parse successfully.In turn, in the
CompiledRunPanel
component, theRun Sampling
button will be disabled if thehandleRun
parameter isundefined
. This prevents a downstream error in model execution caused by the failed parse.I've added a tooltip to the "Run sampling" button that explains to the user why it is disabled in the data-did-not-parse case, and describes the function in the success case. (I also covered the cases where the model is loading or sampling is already in progress.