Additional edits for PR 232 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
WardBrian
reviewed
Oct 30, 2024
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| <picture> | |||
| <source media="(prefers-color-scheme: dark)" srcset="./gui/public/StanPlay_Logo_RGB_White.png"> | |||
| <img alt="The Stan Playground logo" src="./gui/public/StanPlay_Logo_RGB_Full.png" align="right" width=25%> | |||
| <img alt="The Stan Playground logo" src="./gui/public/StanPlay_Logo_RGB_Full.png" style="float: right;" width=25%> | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Reverted. We are still getting the HR cutting through the logo (at least in my browser) but I'm just going to leave it for the time being.
WardBrian
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most controversial things are a) VSCode told me the "align" attribute is deprecated in HTML5, so I replaced it with inline CSS--have to see if it renders right; and also it decided to reformat-on-save the table in
url_parameters.md.