Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide syntax error window by default #73

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

magland
Copy link
Collaborator

@magland magland commented Jun 14, 2024

This replaces #51. Same functionality. Was just easier to start from scratch rather than resolve the conflicts caused by the other PRs.

@WardBrian
Copy link
Collaborator

What does this do with warnings?

a good example is to name a variable “jacobian”. This is going to be a reserved word in a future version of Stan, so for now it gives a compiler warning

@magland
Copy link
Collaborator Author

magland commented Jun 14, 2024

What does this do with warnings?

a good example is to name a variable “jacobian”. This is going to be a reserved word in a future version of Stan, so for now it gives a compiler warning

Good point. Added a button for "Syntax warning"

image

@magland
Copy link
Collaborator Author

magland commented Jun 26, 2024

@WardBrian @jsoules is this okay to merge?

Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps dark orange might be a more appropriate (but still contrasting) color for warnings than blue?

Otherwise this seems fine to me if it's okay with you, @WardBrian

@WardBrian
Copy link
Collaborator

Yep, this is fine by me!

I think we may eventually be able to replace this with something built in to the Monaco editor for showing errors (see #76 and https://github.com/WardBrian/vscode-stan-extension), but this is definitely an improvement over the current behavior

@magland magland merged commit 6e9f7ad into main Jun 26, 2024
1 check passed
@WardBrian WardBrian deleted the hide-syntax-error-window-3 branch June 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants