Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview action #402

Open
rousik opened this issue May 19, 2020 · 4 comments
Open

Fix preview action #402

rousik opened this issue May 19, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@rousik
Copy link
Collaborator

rousik commented May 19, 2020

translation-updated workflow has started failing about ~3 days ago. Preview deployments are pushed to vercel but the script fails to determine/find the deployed url and subsequently fails to update PR with the address.

When I compare last successful run and the first failing one I can see that now CLI has been upgraded between the two runs:

This run uses now cli 17.1.1 and succeeds:
https://github.com/flattenthecurve/guide/runs/643046880?check_suite_focus=true

This run uses now cli 19.0.0 and fails (also prints some warnings):
https://github.com/flattenthecurve/guide/runs/681551510?check_suite_focus=true

@rousik rousik added the bug Something isn't working label May 19, 2020
@rousik
Copy link
Collaborator Author

rousik commented May 20, 2020

@bcardiff fyi

@bcardiff
Copy link
Collaborator

Maybe the action https://github.com/amondnet/now-deployment should be replaced with the new one https://github.com/marketplace/actions/vercel-action .

The argument changed for the new zeit/vercel branding.

@rousik
Copy link
Collaborator Author

rousik commented May 21, 2020

Good idea. PR to do this switch #403 is awaiting your approval.

@rousik
Copy link
Collaborator Author

rousik commented May 28, 2020

The action still can't find the deployment and complains that zeit-team-id is not known argument. I'm not exactly sure what are the values of these secrets and how vercel and now attributes relate to each other... But the change clearly did not make things worse so at least that's nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants