Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _content/es from Lokalise #398

Merged
merged 1 commit into from
May 17, 2020
Merged

Update _content/es from Lokalise #398

merged 1 commit into from
May 17, 2020

Conversation

rousik
Copy link
Collaborator

@rousik rousik commented May 14, 2020

No description provided.

@rousik
Copy link
Collaborator Author

rousik commented May 14, 2020

@monicacecilia, feel free to check the preview build to make sure everything looks good.

@monicacecilia
Copy link
Contributor

Hi @rousik, thanks for the heads up. I had a look and the preview site looks ok. All content is being displayed as it was intended in the last round on Lokalise. I figured out the switch for the svg magic and all images are now being displayed again.
I see that the build is failing a check (up there ^^), but I, of course, leave that to the site experts. :bowtie:
All good from my end!
Thanks again! 🌺

@rousik rousik requested a review from jmcmurry May 16, 2020 00:29
@rousik
Copy link
Collaborator Author

rousik commented May 16, 2020

Looks like build_and_deploy uses some fixed-naming-magic that is broken, @bcardiff fyi.

@rousik rousik requested a review from nditada May 16, 2020 00:31
@bcardiff
Copy link
Collaborator

It seems more an issue of configuration of the secrets in the project.
But it's odd since those didn't change.

compare https://github.com/flattenthecurve/guide/runs/647412560?check_suite_focus=true#step:5:34
and https://github.com/flattenthecurve/guide/runs/675431429?check_suite_focus=true#step:5:49

Yet, the deployment of this PR is available at https://guide-preview-fqj3j3ait.now.sh/

@jmcmurry jmcmurry merged commit 5c83bdd into master May 17, 2020
@rousik
Copy link
Collaborator Author

rousik commented May 19, 2020

@bcardiff I don't think this has to do with secrets because the preview is pushed to vercel, but script then fails to retrieve the deployment url.

I have opened #402 to track this problem. My prime suspect is that version upgrade of now cli causes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants