Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove temp dir if installer fails to download #25392

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Jan 13, 2025

For #25373

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.60%. Comparing base (6235642) to head (b1ce16f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/installer/installer.go 33.33% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #25392    +/-   ##
========================================
  Coverage   63.60%   63.60%            
========================================
  Files        1626     1623     -3     
  Lines      155551   155402   -149     
  Branches     4045     4009    -36     
========================================
- Hits        98941    98848    -93     
+ Misses      48810    48754    -56     
  Partials     7800     7800            
Flag Coverage Δ
backend 64.45% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Approved once a changes file is added, and can be merged once we're out of the fleetd freeze.

iansltx
iansltx previously approved these changes Jan 14, 2025
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to be merged after the fleetd freeze is lifted, but it's ready!

@iansltx iansltx added this to the Fleetd-1.39.0 milestone Jan 17, 2025
@jahzielv jahzielv marked this pull request as ready for review January 29, 2025 23:36
@jahzielv jahzielv requested a review from a team as a code owner January 29, 2025 23:36
@jahzielv jahzielv merged commit 91fe3e2 into main Jan 29, 2025
47 checks passed
@jahzielv jahzielv deleted the 25373-tmp-dir-fix branch January 29, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants