Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android POC #25771

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Android POC #25771

wants to merge 14 commits into from

Conversation

getvictor
Copy link
Member

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 9.91736% with 1853 lines in your changes missing coverage. Please review.

Project coverage is 62.91%. Comparing base (de6a4c3) to head (655a44d).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
server/android/service/transport.go 0.00% 495 Missing ⚠️
server/android/service/endpoint_utils.go 0.00% 361 Missing ⚠️
server/android/service/handler.go 0.00% 178 Missing ⚠️
server/android/service/service.go 0.00% 160 Missing ⚠️
server/android/service/transport_error.go 0.00% 135 Missing ⚠️
server/android/mysql/mysql.go 11.65% 90 Missing and 1 partial ⚠️
server/android/mysql/testing_utils.go 59.44% 69 Missing and 19 partials ⚠️
server/android/job/job.go 0.00% 78 Missing ⚠️
cmd/fleet/serve.go 0.00% 70 Missing ⚠️
server/android/service/endpoint_middleware.go 0.00% 50 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25771      +/-   ##
==========================================
- Coverage   63.59%   62.91%   -0.69%     
==========================================
  Files        1626     1643      +17     
  Lines      155670   157807    +2137     
  Branches     4085     4085              
==========================================
+ Hits        99005    99286     +281     
- Misses      48848    50676    +1828     
- Partials     7817     7845      +28     
Flag Coverage Δ
backend 63.68% <9.91%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/android/service/transport.go Dismissed Show dismissed Hide dismissed
server/android/service/transport.go Dismissed Show dismissed Hide dismissed
server/android/service/transport.go Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant