-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue related to verification of Windows disk encryption #25875
Conversation
…tOrUpdate is called
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25875 +/- ##
=======================================
Coverage 63.60% 63.61%
=======================================
Files 1626 1626
Lines 155526 155526
Branches 4030 4030
=======================================
+ Hits 98923 98933 +10
+ Misses 48803 48795 -8
+ Partials 7800 7798 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few nit comments on the tests.
@PezHub, I wanted to touch base with you regarding the test plan for this ticket. In addition to testing the Windows disk encryption flow itself, we should be sure to keep an eye on this in load testing. The PR modifies how we often update the |
Issue #25723
Addresses Windows-specific issue described in this comment.
Checklist for submitter
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)