Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue related to verification of Windows disk encryption #25875

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

gillespi314
Copy link
Contributor

@gillespi314 gillespi314 commented Jan 29, 2025

Issue #25723

Addresses Windows-specific issue described in this comment.

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

@gillespi314 gillespi314 marked this pull request as ready for review January 30, 2025 15:55
@gillespi314 gillespi314 requested a review from a team as a code owner January 30, 2025 15:55
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.61%. Comparing base (8b23ed5) to head (19e92b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25875   +/-   ##
=======================================
  Coverage   63.60%   63.61%           
=======================================
  Files        1626     1626           
  Lines      155526   155526           
  Branches     4030     4030           
=======================================
+ Hits        98923    98933   +10     
+ Misses      48803    48795    -8     
+ Partials     7800     7798    -2     
Flag Coverage Δ
backend 64.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

getvictor
getvictor previously approved these changes Jan 30, 2025
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few nit comments on the tests.

server/datastore/mysql/microsoft_mdm_test.go Outdated Show resolved Hide resolved
server/datastore/mysql/microsoft_mdm_test.go Outdated Show resolved Hide resolved
server/datastore/mysql/microsoft_mdm_test.go Outdated Show resolved Hide resolved
server/datastore/mysql/microsoft_mdm_test.go Outdated Show resolved Hide resolved
@gillespi314 gillespi314 merged commit 57ae189 into main Feb 3, 2025
25 of 26 checks passed
@gillespi314 gillespi314 deleted the 25723-hde-windows-verifying branch February 3, 2025 15:31
@gillespi314
Copy link
Contributor Author

@PezHub, I wanted to touch base with you regarding the test plan for this ticket. In addition to testing the Windows disk encryption flow itself, we should be sure to keep an eye on this in load testing. The PR modifies how we often update the hosts_disks table, which could place some incremental stress on host checkins. Let me know if you'd like to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants