Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code-formated links not rendering correctly #79

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

lucas-flexcompute
Copy link
Contributor

I've also included a minor format fix in the reference and equation in the introduction of ResonanceFinder.ipynb

Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>
@daquinteroflex
Copy link
Collaborator

Hi Lucas, thanks for raising this, I've made this issue #80 to review in case there are any other notebook with that type of link formatting - which I'll put on my todo list. The rest of the changes look good!

@lucas-flexcompute
Copy link
Contributor Author

lucas-flexcompute commented Mar 7, 2024

Is it ok to merge into develop?

@daquinteroflex
Copy link
Collaborator

daquinteroflex commented Mar 7, 2024

Yep! I can do it if you want? This will propagate into the docs when we update the submodule on tidy3d/latest, and should update in the webcenter example library whenever MC do the next website build I believe.

@daquinteroflex daquinteroflex merged commit 077823b into develop Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants