more fix FieldData

flexcompute · Aug 27, 2024 · b211dc8 · b211dc8
1 parent 505adb7
commit b211dc8
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 5 deletions.
diff --git a/tests/test_components/test_autograd.py b/tests/test_components/test_autograd.py
@@ -36,7 +36,7 @@
 TEST_POLYSLAB_SPEED = False
 
 # whether to run numerical gradient tests, off by default because it runs real simulations
-RUN_NUMERICAL = True
+RUN_NUMERICAL = False
 
 TEST_MODES = ("pipeline", "adjoint", "speed")
 TEST_MODE = "speed" if TEST_POLYSLAB_SPEED else "pipeline"
@@ -618,7 +618,7 @@ def test_polyslab_axis_ops(axis):
 
 
 @pytest.mark.skipif(not RUN_NUMERICAL, reason="Numerical gradient tests runs through web API.")
-@pytest.mark.parametrize("structure_key, monitor_key", (("medium", "field_vol"),))
+@pytest.mark.parametrize("structure_key, monitor_key", (("medium", "mode"),))
 def test_autograd_numerical(structure_key, monitor_key):
     """Test an objective function through tidy3d autograd."""
 

diff --git a/tidy3d/components/data/monitor_data.py b/tidy3d/components/data/monitor_data.py
@@ -1093,14 +1093,44 @@ def shift_value(coords) -> float:
         # Define source dataset
         # Offset coordinates by source center since local coords are assumed in CustomCurrentSource
 
-        # import pdb; pdb.set_trace()
-
         for freq0 in tuple(self.field_components.values())[0].coords["f"]:
             src_field_components = {}
             for name, field_component in self.field_components.items():
                 field_component = field_component.sel(f=freq0)
                 forward_amps = field_component.values
-                values = -1j * forward_amps
+
+                # values = -1j * forward_amps
+                # # rms_error = 0.0012
+                # # |grad| / |grad_num| = 0.6020
+
+                # values = 1 * forward_amps
+                # # rms_error = 2.0000
+                # # |grad| / |grad_num| = 0.2679
+
+                # values = +1j * forward_amps
+                # # rms_error = 2.0000
+                # # |grad| / |grad_num| = 0.6020
+
+                # values = -1 * forward_amps
+                # # rms_error = 0.0013
+                # # |grad| / |grad_num| = 0.2679
+
+                # values = -1j * np.conj(forward_amps)
+                # # rms_error = 2.0000
+                # # |grad| / |grad_num| = 0.0193
+
+                values = np.conj(forward_amps)
+                # rms_error = 0.0012
+                # |grad| / |grad_num| = 0.9772
+
+                # values = +1j * np.conj(forward_amps)
+                # # rms_error = 0.0013
+                # # |grad| / |grad_num| = 0.0193
+
+                # values = -1 * np.conj(forward_amps)
+                # # rms_error = 2.0000
+                # # |grad| / |grad_num| = 0.9772
+
                 if "H" in name:
                     values *= -1
                 coords = dict(field_component.coords.copy())