-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two-photon absorption nonlinearity #1172
Conversation
caseyflex
commented
Sep 25, 2023
•
edited
Loading
edited
- Adds TwoPhotonAbsorption and NonlinearModel classes. Also, nonlinearities of different types can be combined. Note that the beta and n2 parameters for these classes can be complex. Also, these classes need n0, which can be provided or obtained automatically from the medium and source frequencies.
- Adds warning for normalizing against CustomSourceTime or ContinuousWave sources
887bad1
to
28d8e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor comments as I looked over this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! just a few minor comments.
I am a tad unhappy with the naming of |
I am not introducing any breaking changes here. I can rename numiters to num_iters, and keep the old parameter in NonlinearSusceptibility and make it still work for backward compatibility. @tylerflex I would like to move num_iters into NonlinearSpec, rather than duplicating it in every model. Would you be ok with this? I know we didn't want too many specific parameters in the general NonlinearSpec, but I feel this one is sufficiently fundamental to move there. And that would save the user from having to type it in each NonlinearModel. |
As long as you think we can be pretty sure that this will be a field in every nonlinear model we add, specifically that future nonlinear models will not need their own |
9232d2d
to
4c93834
Compare
@tylerflex I added KerrNonlinearity as well as a note about how that relates to chi3 |
cde87aa
to
9df4841
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @caseyflex, pretty minor comments. Still a little confused about the numiters behavior so asked for some clarification (and potentially a strange behavior spotted in a validator), but otherwise looks good.
f50641d
to
6786942
Compare
6786942
to
b336cf6
Compare