📖 DOCS: Multiphysics further docs and minor bug fixes #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
daquinteroflex
commented
Feb 12, 2024
•
daquinteroflex
commented
- Improvements to HEAT API based on notebook examples
- Nice time-varying GIF showing dynamic coupled HEAT and FDTD simulations on the front page, maybe other representative nice images
- Improved docs to the plugins from the README
tylerflex
requested changes
Feb 12, 2024
| @@ -3,6 +3,12 @@ | |||
| Material Thermal Specification | |||
| ------------------------------- | |||
|
|
|||
| To create simulation setups that can be used in different solvers we need to create material specifications that contain all relevant information for each of the solvers. Specifically, when performing coupled thermal and optic simulations, each material definition will contain up to three different characteristic: | |||
There was a problem hiding this comment.
- comma after "used in different solvers".
- pluralize last word ("characteristics")
- in 1-2, comma before "such as"
- 1, 3: optic -> optical?
| @@ -226,6 +234,13 @@ def plot_heat_conductivity( | |||
| ) -> Ax: | |||
| """Plot each of simulation's components on a plane defined by one nonzero x,y,z coordinate. | |||
|
|
|||
| Visualization of [HeatSimulation](./tidy3d.HeatSimulation.html) object displays: | |||
There was a problem hiding this comment.
should these be RST links? seem like markdown format?
|
Haha sorry this is still WIP! I think the PR that was ready for review is #1451 |
|
oh whoops :D sorry |
daquinteroflex
force-pushed
the
dario/multiphysics_animations
branch
from
cffda30
to
330f587
Compare
daquinteroflex
force-pushed
the
dario/multiphysics_animations
branch
from
7365746
to
9cd63c5
Compare
daquinteroflex
changed the title
daquinteroflex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.