Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 TEST: Notebook and reproducible testing configurations refactor #1468

Draft
wants to merge 3 commits into
base: pre/2.6
Choose a base branch
from

Conversation

daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Feb 13, 2024

  • tidy3d develop jupyterlab runs a jupyter lab environement within poetry
  • tidy3d develop test full subcommand including refactored notebooks
  • Single notebook testing reproducible
  • Improved documentation on testing
  • Do we want to include these test scripts inside the dev testing action? Maybe not?

@daquinteroflex daquinteroflex changed the title FEAT: Minor development features 🧪 TEST: Minor development features Apr 10, 2024
@daquinteroflex
Copy link
Collaborator Author

@tylerflex I was thinking this could be a really good intro issue for Matt so he can also get familiar with the API and examples/physics. I am afraid what is the next step can be very repetitive since it involves manually selecting and saving the outputs of corresponding cells. I am happy to do this, but it would probably be pretty interesting for someone getting started with the tool. What do you think?

@daquinteroflex daquinteroflex changed the title 🧪 TEST: Minor development features 🧪 TEST: Notebook and reproducible testing configurations refactor Apr 11, 2024
@tylerflex
Copy link
Collaborator

@tylerflex I was thinking this could be a really good intro issue for Matt so he can also get familiar with the API and examples/physics. I am afraid what is the next step can be very repetitive since it involves manually selecting and saving the outputs of corresponding cells. I am happy to do this, but it would probably be pretty interesting for someone getting started with the tool. What do you think?

Sorry, could you remind me again what this PR is doing? Is the issue generally to come up with a set of reproducible testing environments for releases? It seems to me the main problem within this is a good way to do more automated testing of our notebook examples.

If you think it's better for Matt, that's ok, but maybe could you draft up a front end issue with some more details on what it is he should do?

@daquinteroflex
Copy link
Collaborator Author

Whoops I am very sorry, I actually realised the issue I was referring to was:

flexcompute/tidy3d-notebooks#43.

It was basically finishing setting up the testcases notebook unit tests I meant so we don't have to run all notebooks for every release. This one has just the scripts to run specific tests but I can finish this off.

I can write a set of instructions properly and I think it'll be a pretty good starting issue for Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants