📚 Include mode web api docs #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
looks good to me. thanks Dario. Just wondering why MODE is in all caps? |
|
might prefer just Mode Solver Web API |
alec-flexcompute
approved these changes
Aug 7, 2024
daquinteroflex
force-pushed
the
dario/docs/mode
branch
from
e9b60fd
to
0eb23f2
Compare
|
Sounds good I've updated it. I guess I'm still ingrained subconsciously the MODE, CHARGE naming of Lumerical tools haha. |
tylerflex
approved these changes
Aug 16, 2024
|
@daquinteroflex should we merge this once the notebook submodule is fixed? |
daquinteroflex
force-pushed
the
dario/docs/mode
branch
from
0eb23f2
to
d851687
Compare
|
Hello, sorry this passed me, I will merge as soon as the tests pass! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, included the API for mode simulations as per this https://github.com/flexcompute/tidy3d/blob/develop/tidy3d/web/api/mode.py requested by Alec.