🗻 add cylinder differentiation support #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
changed the title
Closed
tylerflex
force-pushed
the
tyler/autograd_/cylinder2
branch
3 times, most recently
from
6bb5f42
to
dd1809c
Compare
tylerflex
force-pushed
the
tyler/autograd_/cylinder2
branch
from
dd1809c
to
b67bdaa
Compare
tylerflex
requested review from
momchil-flex
and removed request for
yaugenst-flex
|
numerical tests worked with the new parameters and I also tested the metalens notebook again and it's working good. |
tylerflex
force-pushed
the
tyler/autograd_/cylinder2
branch
from
b6340e9
to
0b0bdce
Compare
momchil-flex
approved these changes
Aug 26, 2024
tylerflex
force-pushed
the
tyler/autograd_/cylinder2
branch
from
0b0bdce
to
98db555
Compare
|
ok, should be all resolved. Just squashed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.