mode solver preconditioner improvement and turning off incidence matrix #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliangjin2021
force-pushed
the
weiliang/mode_improvement
branch
from
3bdbc2a
to
5f11c6d
Compare
caseyflex
approved these changes
Sep 6, 2024
weiliangjin2021
force-pushed
the
weiliang/mode_improvement
branch
from
c185438
to
117c4ca
Compare
weiliangjin2021
force-pushed
the
weiliang/mode_improvement
branch
from
117c4ca
to
eec46bd
Compare
weiliangjin2021
commented
Sep 26, 2024
| @@ -22,6 +22,8 @@ | |||
| TOL_TENSORIAL = 1e-6 | |||
| # shift target neff by this value, both rel and abs, whichever results in larger shift | |||
| TARGET_SHIFT = 10 * fp_eps | |||
| # Preconditioner: "Jacobi" or "Material" based | |||
| PRECONDITIONER = "Material" | |||
There was a problem hiding this comment.
Now I also include the previous preconditioning method (Jacobi) along with the new one. For non-magnetic material (mu=1 everywhere), the two are actually very similar. The new one performs better when both epsilon and mu can be huge.
weiliangjin2021
commented
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ax= lambda M x, only eps^-1 and mu^-1 appear inAandM.