Set minimum PML layers to 6 #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momchil-flex
force-pushed
the
momchil/pml-layers
branch
5 times, most recently
from
7ec995d
to
61ef43b
Compare
tylerflex
approved these changes
Nov 12, 2024
momchil-flex
force-pushed
the
momchil/pml-layers
branch
from
61ef43b
to
b81a6a9
Compare
momchil-flex
force-pushed
the
momchil/pml-layers
branch
from
61ef43b
to
23f1700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by MC as a possible improvement. In practice unlikely anything smaller than 6 would make physical sense, and even 6 is probably too little. Had to update various tests.